Skip to content

Prefix dev server cluster ID with 'dev-server-' #1059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NasitSony wants to merge 3 commits into
base: main
Choose a base branch
from
+2 −2
Open

Prefix dev server cluster ID with 'dev-server-' #1059

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cf12193
Prefix dev server cluster ID with 'dev-server-'
NasitSony May 30, 2026
057792c
Merge remote-tracking branch 'upstream/main' into fix/dev-server-clus…
NasitSony May 30, 2026
98f20fa
Merge branch 'main' into fix/dev-server-cluster-id-v2
chaptersix May 31, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions internal/temporalcli/commands.server.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,15 +196,15 @@ func persistentClusterID() string {
file := defaultDeprecatedEnvConfigFile("temporalio", "version-info")
if file == "" {
// No file, can do nothing here
return uuid.NewString()
return "dev-server-" + uuid.NewString()
}
// Try to get existing first
env, _ := readDeprecatedEnvConfigFile(file)
if id := env["default"]["cluster-id"]; id != "" {
return id
}
// Create and try to write
id := uuid.NewString()
id := "dev-server-" + uuid.NewString()
_ = writeDeprecatedEnvConfigFile(file, map[string]map[string]string{"default": {"cluster-id": id}})
return id
}
Expand Down
Loading