Fix/dev server cluster id prefix#1049
Closed
NasitSony wants to merge 6 commits into
Closed
Conversation
…tScheduleMatchingTimes RPC in the CLI. Allows users to preview when a schedule will fire within a given time range without executing workflows. Closes temporalio#1030
Convert SearchAttributes using CustomJSONMarshalOptions before assigning to printableSchedule, ensuring typed fields serialize correctly through standard json.Marshal. Fixes temporalio#590
- Prefix generated cluster IDs with 'dev-server-' for better identification - Add TEMPORAL_DEV_SERVER_CLUSTER_ID env var to allow override Fixes temporalio#609
Contributor
|
@NasitSony please fix your conflict. IMO I don't think it's worth providing an env var to override the cluster id. I'm good with the prefix and closing the issue without adding an env var. |
Contributor
Author
|
@chaptersix Removed the env var override, keeping just the dev-server- prefix. Conflict resolved and tests passing. Ready for review. |
Contributor
Author
|
@chaptersix Closing in favor of #1059 — cleaner branch without extra commits. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was changed
Why?
Dev server cluster IDs were plain UUIDs with no indication they came from a dev server. Prefixing with "dev-server-" makes them identifiable. The env var override allows users to set a consistent cluster ID across restarts without relying on the persisted config file.
Checklist