Skip to content

fix(http): prevent rendering development exception on validation errors #1887

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brendt merged 2 commits into from
Jan 13, 2026
Merged

fix(http): prevent rendering development exception on validation errors #1887

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
98552d8
wip
brendt Jan 13, 2026
ee0508c
wip
brendt Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/http/src/Session/FormSession.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
private const string ORIGINAL_VALUES_KEY = '#original_values';

public function __construct(
private Session $session,
private(set) Session $session,
) {}

/**
Expand Down
6 changes: 6 additions & 0 deletions packages/router/src/Exceptions/HtmlExceptionRenderer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
use Tempest\Http\SensitiveField;
use Tempest\Http\Session\FormSession;
use Tempest\Http\Session\Session;
use Tempest\Http\Session\SessionManager;
use Tempest\Http\Status;
use Tempest\Intl\Translator;
use Tempest\Reflection\ClassReflector;
Expand Down Expand Up @@ -104,6 +105,10 @@ private function shouldRenderDevelopmentException(Throwable $throwable): bool
return false;
}

if ($throwable instanceof ValidationFailed) {
return false;
}

if (! $throwable instanceof HttpRequestFailed) {
return true;
}
Expand All @@ -128,6 +133,7 @@ private function renderValidationFailedResponse(ValidationFailed $exception): Re
if ($this->container->has(Session::class)) {
$this->container->get(FormSession::class)->setErrors($exception->failingRules);
$this->container->get(FormSession::class)->setOriginalValues($this->filterSensitiveFields($this->request, $exception->targetClass));
$this->container->get(SessionManager::class)->save($this->container->get(FormSession::class)->session);
}

$errors = Arr\map($exception->failingRules, fn (array $failingRulesForField, string $field) => Arr\map(
Expand Down