Skip to content

zkCRA PR into merge-create-loan #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
elclandestin0 wants to merge 159 commits into
base: develop
Choose a base branch
from
Open

zkCRA PR into merge-create-loan #378

elclandestin0 wants to merge 159 commits into from

Conversation

@elclandestin0
Copy link
Contributor

@elclandestin0 elclandestin0 commented Jun 12, 2021 •
edited
Loading

We are checking if our zkCRA is computing the interest rate needed to pull out a loan. We use both a good score and a bad. For ease of usage, we added .only() on the loans.test.ts on the zkCRA tests (lines 156-182)

  • Run yarn test mainnet to begin the tests
  • Expected behaviour: all tests should pass

For more information on what our tests are doing, kindly check the helper functions in loans.ts between line 366-672

elclandestin0 and others added 30 commits June 3, 2021 18:30
@elclandestin0
Merge branch 'develop' into feature/merge-create-loan
7fc20ca
@elclandestin0
data provider
dfffc22
@elclandestin0
merge
7c513d1
@elclandestin0
fix compilation errors
eee923c
@elclandestin0
some changes to dp
95eb4d5
@tpscrpt
Skelly for ZK CRA
1ccb5a4
@tpscrpt
Borrow function logic done, need to create loan and add configuration…
031cbc3 
… functions to data provider
@tpscrpt
Add snarks lib
d427b2d
@tpscrpt
Add documentation and fix using collateralAmount instead of collatera…
cb26dae 
…lRatio
@tpscrpt
Into one file
e08f40f
@tpscrpt
Sample handler
c6eb931
@tpscrpt
Updaets
b206dea
@tpscrpt
More clarity on market unctions
07252f2
@elclandestin0
zkCRA test template
059c03c
@tpscrpt
Save
0d6dcd3
@elclandestin0
attempt at fixing comp. errors
3b40eea
@tpscrpt
Fix compilation errors
3f3ed56
@elclandestin0
packed variables
6443352
@elclandestin0
update test
08f7020
@elclandestin0
got witness, output & proof
7a0c7c4
@elclandestin0
set config admins
8c2e977
@elclandestin0
tests almost done
3cc58ab
@elclandestin0
update tests
e76a85b
@tpscrpt
ting
3025c2f
@tpscrpt
Updates
23162c0
@elclandestin0
data being submitted onchain
aa3fe79
@elclandestin0
update tests
dadfc00
@tpscrpt
Keys
26992f1
@tpscrpt
Snark proof verifying
8776bb9
@tpscrpt
YE
cb7ffd1
@elclandestin0
fixed dir structure
3587f25
@elclandestin0
ready for deployment
addb731
@elclandestin0
deployed process request library and teller market handler
6959c2b
@elclandestin0
change to public function
d03861b
@elclandestin0
create provider factory
4990170
@elclandestin0
deployed provider factory
a199943
@elclandestin0
signer successfully set
735c85c
@elclandestin0
provider set in market
8b14b53
@elclandestin0
commitments = number of signatures required
f301a6d
@elclandestin0
end to end testing with good score done
96bef47
@elclandestin0
provider creation with args
351ae5d
@elclandestin0
added provider to request
805ae56
@elclandestin0
end to end testing for bad score completed
0aa513b
@elclandestin0
removed console logs
c9040de
@elclandestin0
changed teller interest value
ebef161
@elclandestin0
removed market lib
13def46
@elclandestin0
fix bad score test
9e2ee4e
@elclandestin0
update
688bb99
@elclandestin0
market handler updated with new loan calculator
50a1f36
@elclandestin0
removed useless require statement
c30bc65
@elclandestin0
states file
784171e
@elclandestin0
retrieve state's rate
47d4887
@elclandestin0
fix bn error
c6b2a29
@elclandestin0
fix market handling rounding error
aeabdd3
@elclandestin0
created new loan facets
6114b1e
@elclandestin0
Merge remote-tracking branch 'origin/zk-cra/market-handler' into zk-c…
ce38b12 
…ra/market-handler
@elclandestin0
Merge pull request #434 from teller-protocol/zk-cra/market-handler
b395cd6 
market handler merge into cra
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ethereumdegen ethereumdegen ethereumdegen left review comments

+2 more reviewers

@passabilities passabilities passabilities requested changes

@dumebi dumebi dumebi left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@elclandestin0 @ethereumdegen @passabilities @dumebi @tpscrpt