Skip to content

chore: fix failing unit tests during upgrade #3441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
anithapriyanatarajan wants to merge 1 commit into
base: dependabot/go_modules/github.com/openshift-pipelines/pipelines-as-code-0.46.0
Choose a base branch
from
+14 −0
Open

chore: fix failing unit tests during upgrade #3441

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions pkg/apis/operator/v1alpha1/openshiftpipelinesascode_defaults_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,9 @@ func TestSetPACControllerDefaultSettings(t *testing.T) {
"secret-github-app-scope-extra-repos": "",
"secret-github-app-token-scoped": "true",
"tekton-dashboard-url": "",
"tracing-label-action": "",
"tracing-label-application": "",
"tracing-label-component": "",
}

assert.DeepEqual(t, opacCR.Spec.PACSettings.Settings, expectedSettings)
Expand Down Expand Up @@ -130,6 +133,9 @@ func TestSetPACControllerLimitedSettings(t *testing.T) {
"secret-github-app-scope-extra-repos": "",
"secret-github-app-token-scoped": "true",
"tekton-dashboard-url": "",
"tracing-label-action": "",
"tracing-label-application": "",
"tracing-label-component": "",
}

assert.DeepEqual(t, opacCR.Spec.PACSettings.Settings, expectedSettings)
Expand Down Expand Up @@ -196,6 +202,9 @@ func TestSetPACControllerDefaultSettingsWithMultipleCatalogs(t *testing.T) {
"secret-github-app-scope-extra-repos": "",
"secret-github-app-token-scoped": "true",
"tekton-dashboard-url": "",
"tracing-label-action": "",
"tracing-label-application": "",
"tracing-label-component": "",
}

assert.DeepEqual(t, opacCR.Spec.PACSettings.Settings, expectedSettings)
Expand Down
5 changes: 5 additions & 0 deletions ...conciler/openshift/openshiftpipelinesascode/testdata/test-expected-additional-pac-cm.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,6 +156,11 @@ data:
custom-console-url-pr-details: ""
custom-console-url-pr-tasklog: ""

# Tracing label names used for distributed tracing of webhook handling and PipelineRun timing.
tracing-label-action: ""
tracing-label-application: ""
tracing-label-component: ""

kind: ConfigMap
metadata:
name: test-config
Expand Down
Loading