Add Windows ARM64 vcpkg target#1370
Conversation
bd074fa to
5ff8f00
Compare
| test-flags: | ||
| description: "Extra flags to pass to `cargo test`" | ||
| required: false | ||
| run-tests: |
There was a problem hiding this comment.
Is there a particular reason ARM doesn't run tests? If any are failing, that may be a sign things need fixed.
There was a problem hiding this comment.
The current ARM64 entry is a cross-build on an x64 runner, so the e2e tests cannot simply run without an emulation layer. Would you prefer that I keep this cross-build-only job or should I add a separate windows-11-arm job for native ARM64 Windows build and test coverage?
There was a problem hiding this comment.
Hm. I think it's fine this way, no strong opinion either way for now.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1370 +/- ##
==========================================
- Coverage 29.54% 29.54% -0.01%
==========================================
Files 273 273
Lines 180506 180506
Branches 180506 180506
==========================================
- Hits 53328 53327 -1
Misses 55476 55476
- Partials 71702 71703 +1
☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
a4fd580 to
5ff8f00
Compare
| test-flags: | ||
| description: "Extra flags to pass to `cargo test`" | ||
| required: false | ||
| run-tests: |
There was a problem hiding this comment.
Hm. I think it's fine this way, no strong opinion either way for now.
| target: ${{ matrix.data.target }} | ||
| publish: ${{ matrix.data.image != 'ubuntu-latest' }} | ||
| run-tests: ${{ matrix.data.run-tests != false }} | ||
| publish: ${{ matrix.data.publish != false && matrix.data.image != 'ubuntu-latest' }} |
There was a problem hiding this comment.
I think something is going wrong here, even the x86_64 vcpkg build didn't publish an artifact.
Edit: Unless that's related to the force-push you just made. I've re-approved CI
There was a problem hiding this comment.
Sorry for the back-and-forth here. I experimented with a native windows-11-arm pipeline, but there's a Cranko setup issue on the ARM64 runner, so I backed that out to keep this PR focused on the cross-build target.
5ff8f00 to
761ac7f
Compare
Summary
This adds vcpkg support for the
aarch64-pc-windows-msvcRust target by:arm64-windows-static-releasevcpkg tripletaarch64-pc-windows-msvcinpackage.metadata.vcpkg.targetVerification
Verified on my fork with a targeted workflow that runs the same prep flow and packages the Windows ARM64 binary:
https://github.com/dakehero/tectonic/actions/runs/26043396816
The workflow completed: