Skip to content

Conversation

@renovate
Copy link
Contributor

@renovate renovate bot commented Dec 6, 2025

This PR contains the following updates:

Package Type Update Change
ghcr.io/danger/danger-swift-with-swiftlint docker minor 3.15.0 -> 3.22.1

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/ghcr.io-danger-danger-swift-with-swiftlint-3.x branch from 5778224 to a74e7c5 Compare December 25, 2025 23:56

- name: Danger
uses: docker://ghcr.io/danger/danger-swift-with-swiftlint:3.15.0
uses: docker://ghcr.io/danger/danger-swift-with-swiftlint:3.22.1
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug: The call to SwiftLint.lint() in Dangerfile.swift uses a deprecated signature that was removed in the updated danger-swift version, which will break the CI pipeline.
Severity: CRITICAL | Confidence: High

🔍 Detailed Analysis

The CI workflow updates the danger-swift version to 3.22.1. However, the Dangerfile.swift contains a call to SwiftLint.lint(inline: false, configFile: ".swiftlint.yml"), which uses a function signature that was removed in danger-swift version 3.20.0. Because the function call is no longer valid with the updated dependency, the Danger job will fail with a compilation or runtime error. This will cause the CI/CD pipeline to crash for all subsequent pull requests, blocking them from being merged.

💡 Suggested Fix

Update the Dangerfile.swift to use the new API for SwiftLint.lint. For example, change the call to SwiftLint.lint(.modifiedAndCreatedFiles(), inline: false, configFile: ".swiftlint.yml") or rely on the default parameters with SwiftLint.lint(configFile: ".swiftlint.yml").

🤖 Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.

Location: .github/workflows/danger.yml#L16

Potential issue: The CI workflow updates the `danger-swift` version to 3.22.1. However,
the `Dangerfile.swift` contains a call to `SwiftLint.lint(inline: false, configFile:
".swiftlint.yml")`, which uses a function signature that was removed in `danger-swift`
version 3.20.0. Because the function call is no longer valid with the updated
dependency, the Danger job will fail with a compilation or runtime error. This will
cause the CI/CD pipeline to crash for all subsequent pull requests, blocking them from
being merged.

Did we get this right? 👍 / 👎 to inform future reviews.
Reference ID: 7934071

@philprime philprime enabled auto-merge (squash) December 26, 2025 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant