fix(share-extension): Add typed error enum #77
Merged
+65
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors the share extension error handling by introducing a proper Swift error enum (ShareExtensionError) to replace the previous NSError instantiation pattern. This improves type safety and follows Swift best practices for error handling.
Key Changes:
- Added a new
ShareExtensionErrorenum conforming toLocalizedErrorwith anoValidURLcase - Updated
ShareViewControllerto use the new typed error instead of manually constructing NSError
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Targets/ShareExtension/Sources/Utils/ShareExtensionError.swift | Introduces new typed error enum with LocalizedError conformance for share extension error cases |
| Targets/ShareExtension/Sources/ShareViewController.swift | Replaces NSError instantiation with new ShareExtensionError.noValidURL when no valid URL is found |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building an NSError object was a quick & dirty solution, so this PR introduces a proper Swift error type.
Closes #76