feat: findEmbeddingsByIds read primitive#62
Open
techiejd wants to merge 7 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds `findEmbeddingsByIds` (public) / `findByIds` (adapter contract): fetch stored embedding records by primary key — including the raw `embedding` vector, which the normal search/query API never returns. Building block for "more like this."
The `id` of each record is whatever `search()` returns as `result.id`, so a search result round-trips directly.
What's here
Contract
Misses dropped (result length may be `< ids.length`); order not guaranteed; empty `ids` → `[]` without a backend call; unknown/malformed ids treated as misses, not errors.
Tests
All green: main `test:int` 86/86 · pg 65/65 · cf 93/93 · mongodb 100/100. Each adapter has a dedicated `findByIds` spec (full record incl. numeric embedding + reserved + extension fields, drop-misses, empty-ids).
Stacking
Based on #61 (`feat/cf-workers-types`), which the CF `findByIds` depends on (unlocks the typed `getByIds`). Merge #61 first, then this retargets to `main`.