-
Notifications
You must be signed in to change notification settings - Fork 953
fix(deps): strip trailing slash from single-segment package paths in resolvePackageNameByPath #10366
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
zkochan
merged 3 commits into
teambit:master
from
zkochan:fix-resolve-pkg-name-trailing-slash
May 12, 2026
+41
−1
Merged
fix(deps): strip trailing slash from single-segment package paths in resolvePackageNameByPath #10366
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| import { expect } from 'chai'; | ||
| import { IssuesClasses } from '@teambit/component-issues'; | ||
| import { Helper } from '@teambit/legacy.e2e-helper'; | ||
|
|
||
| // Regression test: a require/import with a trailing slash like `require('events/')` — | ||
| // a common pattern in webpack browser-fallback configs — should be reported in the | ||
| // MissingPackagesDependenciesOnFs issue under the *package* name (`events`), not the | ||
| // original path (`events/`). Before this fix, `resolvePackageNameByPath` returned the | ||
| // original (non-normalized) string for single-segment paths, so the issue surfaced | ||
| // `events/` and any downstream matching against the real package name failed. | ||
| describe('MissingPackagesDependenciesOnFs strips trailing slash from package names', function () { | ||
| this.timeout(0); | ||
| let helper: Helper; | ||
| let missingPackages: string[]; | ||
| before(() => { | ||
| helper = new Helper(); | ||
| helper.scopeHelper.setWorkspaceWithRemoteScope(); | ||
| // `events` is a Node builtin; the trailing slash bypasses precinct's builtin filter and | ||
| // forces the resolver to look it up as an npm package — but it isn't installed, so it | ||
| // ends up in MissingPackagesDependenciesOnFs. | ||
| helper.fixtures.createComponentBarFoo(`require('events/');`); | ||
| helper.fixtures.addComponentBarFoo(); | ||
| const status = helper.command.statusJson(); | ||
| const issues = status.componentsWithIssues[0]?.issues || []; | ||
| const missingPkgIssue = issues.find((i: any) => i.type === IssuesClasses.MissingPackagesDependenciesOnFs.name); | ||
| missingPackages = missingPkgIssue?.data?.[0]?.missingPackages || []; | ||
| }); | ||
| after(() => { | ||
| helper.scopeHelper.destroy(); | ||
| }); | ||
| it('records the missing package without the trailing slash', () => { | ||
| expect(missingPackages).to.include('events'); | ||
| expect(missingPackages).to.not.include('events/'); | ||
| }); | ||
| }); | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.