fix(deps): resolve missing source-imported packages from the component model on import

e2e/harmony/import-resolves-missing-deps-from-model.e2e.ts

@@ -0,0 +1,40 @@
+import { expect } from 'chai';
+import { Helper } from '@teambit/legacy.e2e-helper';
+
+// Regression test: a component whose source code requires a package that's recorded only in
+// the component's model (not in the workspace policy of the importing workspace) should NOT
+// surface as a MissingPackagesDependenciesOnFs issue after `bit import`. Before the fix in
+// auto-detect-deps.processMissing, when the package wasn't yet in node_modules at the moment
+// dependency resolution ran, it was reported missing — even though the imported component's
+// model already listed it as a packageDependency. The fix consults componentFromModel in
+// processMissing and treats the package as resolved.
+//
+// The test uses --skip-dependency-installation on import so the install step (which can hide
+// the bug by hoisting the package via the scope's dependenciesGraph) doesn't run. That makes
+// the auto-detect path the only thing deciding whether the issue is reported, which is exactly
+// the path the fix targets.
+describe('bit import: missing-package issue suppressed when the model lists the package', function () {
+  this.timeout(0);
+  let helper: Helper;
+  let issueTypes: string[];
+  before(() => {
+    helper = new Helper();
+    helper.scopeHelper.setWorkspaceWithRemoteScope();
+    helper.fixtures.createComponentBarFoo(`require('is-positive');`);
+    helper.fixtures.addComponentBarFoo();
+    helper.command.install('--add-missing-deps');
+    helper.command.tagAllWithoutBuild();
+    helper.command.export();
+
+    helper.scopeHelper.reInitWorkspace();
+    helper.scopeHelper.addRemoteScope();
+    helper.command.importComponentWithoutInstall('bar/foo');
+    issueTypes = helper.command.getAllIssuesFromStatus();
+  });
+  after(() => {
+    helper.scopeHelper.destroy();
+  });
+  it('does not report MissingPackagesDependenciesOnFs for a package present in the model', () => {
+    expect(issueTypes).to.not.include('MissingPackagesDependenciesOnFs');
+  });
+});

scopes/dependencies/dependencies/dependencies-loader/auto-detect-deps.ts

@@ -516,9 +516,21 @@ export class AutoDetectDeps {
     };
     const processMissingPackages = () => {
       if (isEmpty(missing.packages)) return;
-      const missingPackages = missing.packages;
-      if (!isEmpty(missingPackages)) {
-        this._pushToMissingPackagesDependenciesIssues(originFile, missingPackages, fileType);
+      // A newly imported component may import packages whose folders aren't in node_modules yet.
+      // If the model already records them as packageDependencies, treat them as resolved using the
+      // model's version so they end up in the workspace manifest and get installed — rather than
+      // surfacing as MissingPackagesDependenciesOnFs issues.
+      if (this.componentFromModel) {
+        const modelDeps = this.componentFromModel.getAllPackageDependencies();
+        const treePackages = this.tree[originFile].packages;
+        missing.packages = missing.packages.filter((pkgName) => {
+          if (!modelDeps[pkgName]) return true;
+          treePackages[pkgName] = modelDeps[pkgName];
+          return false;
+        });
+      }
+      if (!isEmpty(missing.packages)) {
+        this._pushToMissingPackagesDependenciesIssues(originFile, missing.packages, fileType);
       }
     };
     processMissingFiles();