Skip to content

Fix time parsing for limit cache #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
taylorhakes merged 1 commit into from
Mar 25, 2025
Merged

Fix time parsing for limit cache #45

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion redis_cache/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,9 @@ def get_cache_lua_fn(client):
local limit = tonumber(ARGV[3])
if limit > 0 then
local time_parts = redis.call('TIME')
local time = tonumber(time_parts[1] .. '.' .. time_parts[2])
-- TIME returns [seconds, microseconds] (as strings), so parse each
-- and add together to get the full timestamp
local time = tonumber(time_parts[1]) + (tonumber(time_parts[2]) / 1000000)
redis.call('ZADD', KEYS[2], time, KEYS[1])
local count = tonumber(redis.call('ZCOUNT', KEYS[2], '-inf', '+inf'))
local over = count - limit
Expand Down