fix(window-state): convert macOS coordinates to Logical to fix overlay shrink and multi-monitor DPI scaling drift#3416
Open
gkucmierz wants to merge 2 commits into
Open
Conversation
…y shrink and multi-monitor DPI scaling drift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes a longstanding issue on macOS where the window physically shrinks and drifts across the screen on every restart or multi-monitor movement when using
titleBarStyle: OverlayorTransparent.Changes
update_state,restore_state, and event handlers fromPhysicaltoLogical. Saving physical coordinates causes severe positional and scale drift when moving windows between monitors of different DPIs (e.g., dragging from a Retina 2x display to an external 1x 1080p display).SIZEcache update. When anOverlaytitlebar causes theinner_sizeto report 28px smaller than theouter_size, the plugin now correctly caches the outer dimensions to prevent cascading shrinkage on subsequent launches.This patch comprehensively stabilizes window boundaries and restoration logic across complex macOS multi-monitor setups.