fix(sql): bindTypes hint to correctly bind binary data (fix #105)#3125
fix(sql): bindTypes hint to correctly bind binary data (fix #105)#3125liuzhch1 wants to merge 1 commit intotauri-apps:v2from
Conversation
I think we should convert it to uint8array. Consider if we change to other effective way to transmit data as binary(eg msg pack) in future, the BLOB data directly come to JS as uint8array. To keep api the same(return number[]), we need to convert Array.from(uint8array) then give it to user. However user might do need uint8array format since it is a blob, so they need to convert it back Uint8Array(number[]). Those converts do take time and memory ... just some thoughts comes to my mind, maybe it's overkill for now. api breaking change might be accepted in future version or additional api can be added.. and user can invoke |
which was my argument to not do these conversations on our side but i don't care too much since number[] -> uint8array should be relatively cheap. |
|
p.s. i'm a bit busy today so will take a look tomorrow, sry |
Package Changes Through 34d7de3There are 17 changes which include dialog-js with minor, dialog with minor, log with minor, log-js with minor, localhost with patch, barcode-scanner with patch, barcode-scanner-js with patch, http with patch, http-js with patch, nfc with patch, nfc-js with patch, updater with minor, updater-js with minor, upload with minor, upload-js with minor, websocket with patch, websocket-js with patch Planned Package VersionsThe following package releases are the planned based on the context of changes in this pull request.
Add another change file through the GitHub UI by following this link. Read about change files or the docs at github.com/jbolda/covector |
|
yeah sure, no worries let's use number[] for now. |
fix #105
WIP
Currently only implemented the sqlite part. I'd add mysql and postgres parts once we decided to use this approach(just copy paste I think).