Skip to content

Conversation

@junngo
Copy link
Contributor

@junngo junngo commented Nov 3, 2025

Some workers run in dynamically generated working directories (e.g., D:\task_17612\ or /home/cltbld/tasks/task_17612/), which means the upload path isn’t always static.
Previously, we relied on UPLOAD_DIR when generating the artifact, but not all jobs expose this environment variable, which caused inconsistencies.
To fix this, we added a new environment variable, PERFHERDER_FETCH_CONTENT_JSON_PATH[0]. It gives us a clear and reliable file path, so we can always generate the perfherder-data-fetch-content.json artifact correctly on any worker.

[0]
Related patch (mozilla-central): https://phabricator.services.mozilla.com/D270831
Bugzilla link: https://bugzilla.mozilla.org/show_bug.cgi?id=1996563

@junngo junngo requested a review from a team as a code owner November 3, 2025 12:47
@junngo junngo requested a review from hneiva November 3, 2025 12:47
@junngo junngo marked this pull request as draft November 4, 2025 07:00
@junngo junngo force-pushed the ensure-fetch-content-perfherder branch from 06d83f1 to af79673 Compare November 4, 2025 12:02
@junngo
Copy link
Contributor Author

junngo commented Nov 7, 2025

I modified the code directly in mozilla-central to test it. Here is the CI test I ran. [0]
We can see that the perfherder-data-fetch-content.json artifact is generated correctly.
If there is anything else I should change, please feel free to let me know :)

[0]
https://treeherder.mozilla.org/jobs?repo=try&revision=70d74fb69a4c26602893c0ff7d9bdaa5f59ef18b
https://treeherder.mozilla.org/jobs?repo=try&revision=70d74fb69a4c26602893c0ff7d9bdaa5f59ef18b&selectedTaskRun=WJyjic9zQOqFbM6ctfMdyA.0

@junngo junngo marked this pull request as ready for review November 7, 2025 11:32
@bhearsum bhearsum merged commit d4f72f7 into taskcluster:main Nov 13, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants