Skip to content

lib/cluster: remove file/env collectors superseded by go-config#1282

Open
bigbes wants to merge 3 commits into
v3from
bigbes/tntp-7389-tt-config-intial
Open

lib/cluster: remove file/env collectors superseded by go-config#1282
bigbes wants to merge 3 commits into
v3from
bigbes/tntp-7389-tt-config-intial

Conversation

@bigbes
Copy link
Copy Markdown
Collaborator

@bigbes bigbes commented Apr 29, 2026

go-config ships a Tarantool builder with schema-aware env var resolution and an embedded JSON Schema, so the hand-maintained file/env collectors in lib/cluster are no longer needed by cli/cluster.

Closes TNTP-7389

@bigbes bigbes requested a review from sssciel April 29, 2026 23:48
@bigbes bigbes marked this pull request as draft April 30, 2026 13:24
@bigbes bigbes force-pushed the bigbes/tntp-7389-tt-config-intial branch 3 times, most recently from 5765e13 to e2a3ef3 Compare May 5, 2026 15:01
@bigbes bigbes marked this pull request as ready for review May 6, 2026 05:40
@bigbes bigbes force-pushed the bigbes/tntp-7389-tt-config-intial branch from 949f3af to 7b5dce2 Compare May 6, 2026 05:53
@bigbes bigbes requested a review from patapenka-alexey May 6, 2026 12:46
@bigbes bigbes added full-ci Enables full ci tests ee-ci EE tests for outside pull requests and removed ee-ci EE tests for outside pull requests full-ci Enables full ci tests labels May 6, 2026
Copy link
Copy Markdown
Member

@sssciel sssciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is red

bigbes added 3 commits May 6, 2026 19:01
go-config ships a Tarantool builder with schema-aware env var resolution and an
embedded JSON Schema, so the hand-maintained file/env collectors in lib/cluster
are no longer needed by cli/cluster.

Closes TNTP-7389
t.TempDir() returns /var/... but os.Getwd() resolves to /private/var/...
on macOS, mismatching expected paths. EvalSymlinks tstDir once.
box.schema.space.create lacked if_not_exists; on restart the recovered
space made create kill the instance. Fixture hardlinked across 5 dirs.
@bigbes bigbes force-pushed the bigbes/tntp-7389-tt-config-intial branch from 7b5dce2 to 82fabf7 Compare May 6, 2026 16:03
@bigbes bigbes requested a review from sssciel May 6, 2026 18:13
@bigbes bigbes added the forbid-merge should not allow merging label May 7, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

forbid-merge should not allow merging full-ci Enables full ci tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants