lib/cluster: remove file/env collectors superseded by go-config#1282
Open
bigbes wants to merge 3 commits into
Open
lib/cluster: remove file/env collectors superseded by go-config#1282bigbes wants to merge 3 commits into
bigbes wants to merge 3 commits into
Conversation
5765e13 to
e2a3ef3
Compare
949f3af to
7b5dce2
Compare
sssciel
approved these changes
May 6, 2026
go-config ships a Tarantool builder with schema-aware env var resolution and an embedded JSON Schema, so the hand-maintained file/env collectors in lib/cluster are no longer needed by cli/cluster. Closes TNTP-7389
t.TempDir() returns /var/... but os.Getwd() resolves to /private/var/... on macOS, mismatching expected paths. EvalSymlinks tstDir once.
box.schema.space.create lacked if_not_exists; on restart the recovered space made create kill the instance. Fixture hardlinked across 5 dirs.
7b5dce2 to
82fabf7
Compare
sssciel
approved these changes
May 6, 2026
patapenka-alexey
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go-config ships a Tarantool builder with schema-aware env var resolution and an embedded JSON Schema, so the hand-maintained file/env collectors in lib/cluster are no longer needed by cli/cluster.
Closes TNTP-7389