Feat: add option closeAllByClosing #299
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Close all non-closed elements when containing element closes. To fix issue taoqf#294. Added as an option so that behaviour does not change for those who do not opt in to the new behaviour.
Intention was to add it as a devDependency, but added it as a dependency by mistake.
Move tests of option closeAllByClose to test/tests/unclosedtags.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If option closeAllByClosing is set to true, then all unclosed elements are closed at the end of their parent element.
This is done only after all usual heuristics for closing tags based on opening and closing tags have been exercised, to catch and close any remaining unclosed elements.
This ensures that where there is a parent element, all nested elements are closed by the close of the parent.
This will allow some cases of invalid HTML to be parsed and manipulated which otherwise might fail.