4.3.0#20023
Conversation
Just happened to run into this in the release branch...
```diff
- --- ./dist/assets/index-<hash>.css ---
+ --- ./dist/assets/index-B_aD48aL.css ---
.do-include-me {
color: green;
}
```
For context, when we deal with Vite related integration tests, we build
a CSS file, and dump all the generated files (file path + contents).
Since Vite uses a hash in the filename, we stripped it and replaced it
with `<hash>` because the hash doesn't matter for the tests.
We just happen to run into a situation where a `_` character was used
and our regex didn't match.
Long story short, this is a small internal change that doesn't need any
kind of changelog entry.
RobinMalfait
force-pushed
the
release/4.3.0
branch
from
094a9d1 to
cb4a2d7
Compare
Confidence Score: 5/5Safe to merge — this is a straightforward release bump with no logic changes beyond removing experimental guards from already-tested utilities. All package versions are consistently updated to 4.3.0, the CHANGELOG is correctly structured, the feature flags have no remaining import sites, and the test regex fix is a targeted correctness improvement. The only leftover artifact is the now-empty feature-flags.ts file, which causes no runtime impact. packages/tailwindcss/src/feature-flags.ts — left empty after flag removal; could simply be deleted. Reviews (3): Last reviewed commit: "update date" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThis release promotes scrollbar utilities and 🚥 Pre-merge checks | ✅ 2 | ❌ 2❌ Failed checks (2 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
packages/tailwindcss/src/utilities.ts (1)
5940-5941: 💤 Low valueConsider adding
sizeto the suggestions.Now that
@container-sizeis promoted to stable, the suggestion block should includesizeas a valid value for autocomplete discoverability.♻️ Suggested fix
suggest('@container', () => [ { - values: ['normal'], + values: ['normal', 'size'], valueThemeKeys: [], hasDefaultValue: true, }, ])Also applies to: 5953-5959
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/tailwindcss/src/utilities.ts` around lines 5940 - 5941, The suggestions logic currently omits the stable container value "size": update the branch that checks candidate.value.kind === 'named' and candidate.value.value === 'size' to set value = 'size' and ensure any suggestions array or completion list that handles container query values includes 'size' as an option; apply the same change to the other occurrence of the same named-value handling (the second block handling candidate.value.kind === 'named' for container values) so both places return or push 'size' into the suggestions/completions.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@packages/tailwindcss/src/utilities.ts`:
- Around line 5940-5941: The suggestions logic currently omits the stable
container value "size": update the branch that checks candidate.value.kind ===
'named' and candidate.value.value === 'size' to set value = 'size' and ensure
any suggestions array or completion list that handles container query values
includes 'size' as an option; apply the same change to the other occurrence of
the same named-value handling (the second block handling candidate.value.kind
=== 'named' for container values) so both places return or push 'size' into the
suggestions/completions.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository UI
Review profile: CHILL
Plan: Pro
Run ID: a2e3d18e-350d-4f47-90e9-0c915603c5f8
📒 Files selected for processing (27)
CHANGELOG.mdcrates/node/npm/android-arm-eabi/package.jsoncrates/node/npm/android-arm64/package.jsoncrates/node/npm/darwin-arm64/package.jsoncrates/node/npm/darwin-x64/package.jsoncrates/node/npm/freebsd-x64/package.jsoncrates/node/npm/linux-arm-gnueabihf/package.jsoncrates/node/npm/linux-arm64-gnu/package.jsoncrates/node/npm/linux-arm64-musl/package.jsoncrates/node/npm/linux-x64-gnu/package.jsoncrates/node/npm/linux-x64-musl/package.jsoncrates/node/npm/wasm32-wasi/package.jsoncrates/node/npm/win32-arm64-msvc/package.jsoncrates/node/npm/win32-x64-msvc/package.jsoncrates/node/package.jsonintegrations/vite/resolvers.test.tspackages/@tailwindcss-browser/package.jsonpackages/@tailwindcss-cli/package.jsonpackages/@tailwindcss-node/package.jsonpackages/@tailwindcss-postcss/package.jsonpackages/@tailwindcss-standalone/package.jsonpackages/@tailwindcss-upgrade/package.jsonpackages/@tailwindcss-vite/package.jsonpackages/@tailwindcss-webpack/package.jsonpackages/tailwindcss/package.jsonpackages/tailwindcss/src/feature-flags.tspackages/tailwindcss/src/utilities.ts
💤 Files with no reviewable changes (1)
- packages/tailwindcss/src/feature-flags.ts
|
Want your agent to iterate on Greptile's feedback? Try greploops. |
1 participant
No description provided.