fix: handle invalid UTF-8 in Ruby and Vue preprocessors #19588
+80
−42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a panic that occurs when the Ruby or Vue preprocessors encounter files with invalid UTF-8 bytes.
The issue:
ruby.rs:37andvue.rs:18usedstd::str::from_utf8(content).unwrap()Error message:
The fix:
if let Ok(...)to gracefully handle invalid UTF-8This can happen in Rails projects when:
Test plan
test_invalid_utf8_does_not_panictest for Ruby preprocessortest_valid_utf8_with_multibyte_charstest for Ruby preprocessortest_invalid_utf8_does_not_panictest for Vue preprocessorcargo test pre_processors- 43 tests)