Skip to content

Small structural markup fix in hero.tsx #2479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vedanshshetti wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Small structural markup fix in hero.tsx #2479

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 15 additions & 10 deletions src/components/home/hero.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,13 @@ const Hero: React.FC = () => {
<span className="hidden sm:max-md:inline">text-5xl </span>
<span className="hidden lg:max-xl:inline">text-6xl </span>
<span className="hidden xl:inline">text-8xl </span>
<span className="inline dark:hidden">text-gray-950 </span>
<span className="hidden dark:inline">text-white </span>tracking-tighter{" "}
<span className="max-sm:hidden">text-balance</span>
{/* Color classes */}
<span className="inline dark:hidden text-gray-950">text-gray-950 </span>
<span className="dark:inline not-dark:hidden text-white!">text-white </span>
{/* Typography classes */}
<span className="inline">tracking-tighter </span>
<span className="max-sm:hidden">text-balance </span>

</div>
<GridContainer>
<h1 className="px-2 text-4xl tracking-tighter text-balance max-lg:font-medium max-sm:px-4 sm:text-5xl lg:text-6xl xl:text-8xl">
Expand All @@ -70,8 +74,9 @@ const Hero: React.FC = () => {
aria-hidden="true"
className="flex h-6 items-end px-2 font-mono text-xs/6 whitespace-pre text-black/20 max-sm:px-4 sm:h-10 dark:text-white/25"
>
text-lg <span className="inline dark:hidden">text-gray-950</span>
<span className="hidden dark:inline">text-white</span> font-medium
<span className="inline">text-lg </span>
<span className="inline dark:hidden">text-gray-950 </span>
<span className="inline dark:hidden">font-medium</span>
</div>
<GridContainer>
<p className="max-w-(--breakpoint-md) px-2 text-lg/7 font-medium text-gray-600 max-sm:px-4 dark:text-gray-400">
Expand Down Expand Up @@ -106,11 +111,11 @@ const Hero: React.FC = () => {
/>
</svg>
Quick search
<kbd className="hidden font-sans text-xs/4 text-gray-500 dark:text-gray-400 [.os-macos_&]:block">
<span className="opacity-60">⌘</span>K
<kbd className="hidden font-sans text-xs/4 text-gray-500 dark:text-gray-400 in-[.os-macos]:block">
<span className="opacity-60">⌘</span>&nbsp;+&nbsp;K
</kbd>
<kbd className="hidden font-sans text-xs/4 text-gray-500 not-[.os-macos_&]:block dark:text-gray-400">
<span className="opacity-60">Ctrl</span>&nbsp;K
<kbd className="hidden font-sans text-xs/4 text-gray-500 not-[.os-macos]:block dark:text-gray-400">
<span className="opacity-60">Ctrl</span>&nbsp;+&nbsp;K
</kbd>
</SearchButton>
</div>
Expand All @@ -122,7 +127,7 @@ const Hero: React.FC = () => {
<div
className={clsx(
"*:flex *:*:max-w-none *:*:shrink-0 *:*:grow *:overflow-auto *:rounded-lg *:bg-white/10! *:p-5 dark:*:bg-white/5!",
"**:[.line]:isolate **:[.line]:block **:[.line]:not-last:min-h-[1lh]",
"**:[.line]:isolate **:[.line]:block **:[.line]:not-last:min-h-lh",
"*:inset-ring *:inset-ring-white/10 dark:*:inset-ring-white/5",
)}
>
Expand Down