feat(vite-plugin): add entrypoint option to scope auto-inject to a single file#96
Open
feat(vite-plugin): add entrypoint option to scope auto-inject to a single file#96
Conversation
IzumiSy
force-pushed
the
feat/entrypoint-required
branch
from
78c41a8 to
253ff2a
Compare
commit: |
Contributor
Author
|
/review |
Contributor
Author
|
API design review agent did no-op. No meaningful review comment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
entrypointoption toappShellRoutes()to scope auto-inject interception to a single file.Problem
The current auto-inject plugin intercepts all user-code imports of
@tailor-platform/app-shelland replaces them with a proxy. This creates a circular dependency in the module graph (proxy → pages → page components → proxy). This circular dependency can cause issues such as TDZ errors from uninitialized bindings and unexpected module evaluation order, depending on what page components import or execute at the top level.Solution
When
entrypointis specified, only imports from that file are intercepted. All other files import directly from the real package, structurally eliminating the circular dependency.The option is optional — when omitted, the existing behavior is preserved. Setting it is recommended for safety.