Closed
Conversation
The README states M2+ is required, but spank builds and runs successfully on Apple M1 Pro (MacBookPro18,1). The M1 Pro has an accelerometer exposed via IOKit HID (SPI transport, VendorID 1452, ProductID 835) that is compatible with the sensor reading code. Tested on: - Chip: Apple M1 Pro (10-core, 16GB) - Model: MacBookPro18,1 (16-inch, 2021) - macOS: 15.2 (Sequoia, build 24C101) - Go: 1.26.0 (auto-toolchain from 1.25.6) Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
+1 (16" M1 Max) |
Owner
|
thanks, but if we include a table like this is insinuates that all other platforms haven't been tested. M1Pro/Max work, and anything M2+ works as well (laptops only) so if you want to add those models to the table I can merge but otherwise this is actually more misleading I feel |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The README currently lists M2+ as a requirement, but spank builds and runs successfully on Apple M1 Pro. This PR adds a "Confirmed Working Hardware" table to document tested configurations beyond M2.
Machine Details
Accelerometer Info (via
ioreg)AccelerometerAppleHIDTransportHIDDeviceThe accelerometer is exposed as an HID device on the SPI bus, bundled with the internal keyboard/trackpad — same IOKit HID path that spank uses for sensor access.
What was tested
go buildcompiles cleanlysudoand detects the accelerometer hardwareThis suggests the M2+ requirement could be relaxed to M1 Pro+ (and possibly other M1 variants).
🤖 Generated with Claude Code