feat: Add Protobuf log handler, improve CI toolchain, and enhance code generation#155
Open
feat: Add Protobuf log handler, improve CI toolchain, and enhance code generation#155
Conversation
Kybxd
force-pushed
the
csharp-custom-conf
branch
from
a09ff3f to
0aaf1b7
Compare
- Update C# testing workflow to use arduino/setup-protoc for Protoc installation - Convert multiple const std::string& to const std::string for better string handling - Remove unused Protobuf log handler related code
refactor: Unify matrix-driven Go setup across CI workflows ci: Unify init script handling across platforms chore: Enforce C++17 and simplify build setup chore: Downgrade Protoc and add CMake policy in CI workflows chore: Downgrade setup-protoc & simplify init scripts chore: Update Protoc version format to include 'v' prefix chore: Align protobuf paths and downgrade setup-protoc chore: Unify protobuf setup across OSes in CI
Kybxd
force-pushed
the
csharp-custom-conf
branch
from
0cd8232 to
142ffcb
Compare
Kybxd
changed the title
Kybxd
force-pushed
the
csharp-custom-conf
branch
6 times, most recently
from
862febc to
81ee4bb
Compare
refactor: Switch to version-based Protobuf log handler guards
Kybxd
force-pushed
the
csharp-custom-conf
branch
from
81ee4bb to
8bb4bde
Compare
Kybxd
changed the title
wenchy
requested changes
Mar 26, 2026
| std::shared_ptr<const MessagerOptions> options /* = nullptr*/) { | ||
| options = options ? options : std::make_shared<MessagerOptions>(); | ||
| const std::string& name = msg.GetDescriptor()->name(); | ||
| const std::string name(msg.GetDescriptor()->name()); |
Member
There was a problem hiding this comment.
Use string_view ?
https://en.cppreference.com/w/cpp/string/basic_string_view.html
Member
There was a problem hiding this comment.
Should add comment:
For compatibility, the new protobuf API returned std::string_view type, so here must casting it to std::string.
|
|
||
| - name: Install Protoc | ||
| uses: arduino/setup-protoc@v3 | ||
| uses: arduino/setup-protoc@v1 |
Member
There was a problem hiding this comment.
Please use v3 instead (AI is missing this case).
| static void Main(string[] _) | ||
| { | ||
| Tableau.Registry.Init(); | ||
| Tableau.Registry.Register<Custom.CustomItemConf>(); |
Member
There was a problem hiding this comment.
Call the GetSpecialItemName and check it for expected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This MR introduces Protobuf log handler support with cross-version compatibility, improves CI build toolchain, and enhances C++ code generation quality.
Changes
Protobuf Log Handler (
61b3b7f)ProtobufLogHandler) and ABSL log sink (ProtobufAbslLogSink) with version-based guards (TABLEAU_PB_LOG_LEGACY)TABLEAU_PB_LOG_*macros for cross-version compatibilityconst std::string¶meters toconst std::stringfor better string handlingCI & Build Toolchain (
57049b3)Code Generation Style (
2f9e33e)// clang-format offcomment to all generated.pc.ccand.pc.hfileshelper.go) to emit the directive automaticallyC# Testing (
7823b62)CustomItemConfclass for C# testing