Potential partial fix for #120#121
Draft
ianjosephwilson wants to merge 3 commits into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is close to what we tried in the parser before. I have to reach out to the
SourceTrackerto get the information which I guess is ok. This only pre-slices the children template it does not actually parse it. The parsing will happen if a component returns the template after processing and it is fed through the normal flow, ie. "_process_template()". I think we could probably go all-in somehow here and try to parse out all the component templates and feed them back into the cache but it seems like ... a lot. My original version of this didn't useTemplateRefit seems to fit here even if thestringsmight be a little redundant with the total template.I'm going to think about this and maybe a better idea will come up. Maybe I'll try the "all-in" version and see if it looks better for some reason.