Skip to content

Enables code snippet previews#1

Open
bencmbrook wants to merge 1 commit into
t-mrt:masterfrom
bencmbrook:bencmbrook/snippet-previews
Open

Enables code snippet previews#1
bencmbrook wants to merge 1 commit into
t-mrt:masterfrom
bencmbrook:bencmbrook/snippet-previews

Conversation

@bencmbrook
Copy link
Copy Markdown

@bencmbrook bencmbrook commented Nov 26, 2018

This commit removes the slash before the hash (/#L9 --> #L9). Github permalinks should not include this slash before the hash (the slash still works for linking but breaks code snippet previews)

Effect of change:

Pasting a permalink before
https://github.com/t-mrt/copy-github-url/blob/b7a936b43d455c13effe76a1b27a6f65732b8e85/src/copy-github-URL.ts/#L43

and after

const u = url.parse(`https://${args.domain}/${args.repository}/blob/${args.commit}/${args.filePath}/#${L}`);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant