Skip to content

Conversation

@jamuir
Copy link
Contributor

@jamuir jamuir commented Jan 28, 2025

Some of the comments summarizing the configuration/options could be confusing. E.g., "f" was used for "Filtering", but "-f" is the command-line option used to specify the sample frequency. Also, "hz" was used but there is no command-line option or config directive that mentions "hertz".

Change the summmary to use the names from the config file. Update the sample config file so it is more obvious what is parsed as a float, and also include "Cmdline", which was missing.

Some of the comments summarizing the configuration/options could be
confusing.  E.g., "f" was used for "Filtering", but "-f" is the
command-line option used to specify the sample frequency.  Also, "hz"
was used but there is no command-line option or config directive that
mentions "hertz".

Change the summmary to use the names from the config file.  Update the
sample config file so it is more obvious what is parsed as a float,
and also include "Cmdline", which was missing.
@jamuir
Copy link
Contributor Author

jamuir commented Jan 28, 2025

Here is what the updated summary looks like:

<!-- This file is a bootchart SVG file. It is best rendered in a browser -->
<!-- such as Chrome, Chromium, or Firefox. Other applications that       -->
<!-- render these files properly but more slowly are ImageMagick, gimp,  -->
<!-- inkscape, etc. To display the files on your system, just point      -->
<!-- your browser to file:///run/log (the default location) and click.   -->

<!-- This file was generated by bootchart version 235, running with configuration:  -->

<!-- Samples=300 -->
<!-- Frequency=10.000000 -->
<!-- Relative=0 -->
<!-- Filter=1 -->
<!-- Output=/tmp -->
<!-- Init=/usr/lib/systemd/systemd -->
<!-- PlotMemoryUsage=0 -->
<!-- PlotEntropyGraph=0 -->
<!-- ScaleX=100.000000 -->
<!-- ScaleY=20.000000 -->
<!-- ControlGroup=0 -->
<!-- PerCPU=0 -->
<!-- Cmdline=1 -->

Note that the quotes around the values have been dropped.

Copy link
Contributor

@sofar sofar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No comments from my side. These are all reasonable changes.

Copy link
Member

@keszybz keszybz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable…

@keszybz keszybz merged commit 65c3927 into systemd:main Feb 15, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants