Keep working with PID#1 #57
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do not skip the first sample for PID#1 The continue statement was introduced very early with commit 5da71e1 in the original reposiotory before bootchart was merged into systemd, when there was little code at the end of the while loop and apparently skipping it didn't hurt. Specifically commit 9b004a7 introduces still_runnig flag which is never set for PID#1 which makes it subject to garbage collection in garbage_collect_dead_processes().
bluca
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not skip the first sample for PID#1
The continue statement was introduced very early with commit 5da71e1 in the original reposiotory before bootchart was merged into systemd, when there was little code at the end of the while loop and apparently skipping it didn't hurt. Specifically commit 9b004a7 introduces still_runnig flag which is never set for PID#1 which makes it subject to garbage collection in garbage_collect_dead_processes().