Fix watcher deletion sync bugs and improve file download resilience#111
Merged
zephyranthes03 merged 1 commit intostagingfrom Feb 10, 2026
Merged
Fix watcher deletion sync bugs and improve file download resilience#111zephyranthes03 merged 1 commit intostagingfrom
zephyranthes03 merged 1 commit intostagingfrom
Conversation
- Fix watcher deletion using wrong IDs (client ID → server ID mapping)
- get_all_groups_with_watchers now returns server watcher IDs
- batch_soft_delete_watchers uses server_watcher_id column
- get_all_soft_deleted_items uses correct JOIN column (group_id)
- Fix SyncConfiguration response missing data
- Populate deleted_items (field 12) from explicit/diff-based deletions
- Track files_soft_deleted count for individual watcher deletes
- Include soft-delete timestamps in server_latest_ts calculation
via new get_latest_config_timestamp storage method
- Improve file download error handling
- Unary handler: pre-check data existence before 'too large' redirect
- Streaming handler: fallback to FileService when storage stream
returns None (handles S3 migration gaps)
- Add diagnostic logging for storage type and file size on failures
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix watcher deletion using wrong IDs (client ID → server ID mapping)
Fix SyncConfiguration response missing data
Improve file download error handling