fix(sandbox): isUnderDirectory returns true for root directory#1
Open
tdiam wants to merge 1 commit intosysid:mainfrom
Open
fix(sandbox): isUnderDirectory returns true for root directory#1tdiam wants to merge 1 commit intosysid:mainfrom
tdiam wants to merge 1 commit intosysid:mainfrom
Conversation
Fix bug where isUnderDirectory('/home/user', '/') returned false.
When dirPath is '/', the check normalizedFile.startsWith('${normalizedDir}/')
became startsWith('//') which never matches.
Now handles root directory specially by using '/' as the prefix
instead of '//'.
This fix makes denyRead: ['/'] in sandbox.json work correctly.
tdiam
force-pushed
the
fix/isUnderDirectory-root-path
branch
2 times, most recently
from
b95c778 to
e713662
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix bug where
isUnderDirectory('/home/user', '/')returnedfalse, makingdenyRead: ["/"]insandbox.jsonineffective.Problem
When
dirPathis"/", the check:became
startsWith("//")which never matches any normalized path.Changes
path-guard.ts: Fix root directory handling in both the non-symlink and symlink code pathspath-guard.test.ts: Add tests for root directory cases