🌱 Support hrobot:// ProviderID of upstream ccm.#72
Open
Conversation
janiskemper
reviewed
Jan 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Support
hrobot://ProviderID from upstream CCMWe want to support this use case: someone runs the upstream CCM in their cluster, then switches back to the legacy
syself-ccm. In that scenario, Nodes with ahrobot://ProviderID may already exist.Additionally, we want that the Syself ccm can create the new format.
This PR includes
Reading ProviderID
When the CCM reads a bare-metal Node’s ProviderID, it supports both formats:
hcloud://bm-NNNNhrobot://NNNNWriting InstanceMetadata (ProviderID format)
ccmwas started with the flag--use-hrobot-provider-id-for-baremetal. If that flag was set, then thehrobot://NNNNformat gets used.Background
A Node’s ProviderID is only set once during bootstrapping. After it’s set, it never changes.
Both the upstream Hetzner CCM and (after this PR)
syself-ccmsupport both formats, so existing Nodes are fine.HCloud nodes are not affected by this change.
Attention: Your duty!
During bootstraping a new node, CAPI Provider Hetzner (CAPH) and the CCM must agree on the same ProviderID format. It is your duty to ensure that.
Alternative
If you start the kubelet with
--provider-id XXXX, then the CCM does not set it.Related:
✨ Support upstream hcloud-ccm. ProviderID changes to
hrobot://NNNNNby guettli · Pull Request #1703 · syself/cluster-api-provider-hetzner