Conversation
remcohaszing
approved these changes
Mar 19, 2026
There was a problem hiding this comment.
Pull request overview
This PR adjusts the TypeScript surface of h/s so their second argument can be typed as a union of Child and Properties (matching actual runtime behavior), which helps consumers that pass values like node.attributes from remark-directive without extra casts/defaults.
Changes:
- Update JSDoc overload in
createHto acceptChild | Propertiesas the second parameter. - Add a
tsdtype test that verifies aChild | Properties-typed value is accepted as the second argument toh.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test-d/index.ts | Adds a type-level regression test for passing a Child | Properties union as the second argument. |
| lib/create-h.js | Updates the overload signature to reflect that the second parameter can be either Child or Properties. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Initial checklist
Description of changes
The second parameter accepts
ChildorPropertiesat the same time actually, and when usingnode.attributesviaremark-directive, there is no need to add|| {}athttps://github.com/remarkjs/remark-directive/blob/23b8f416da165b6ddaa4c5e7e82addaf6dcb96a9/readme.md?plain=1#L161