feat: calculator v61 redesign#554
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c2d065d16
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ovitrif
changed the title
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 76f4cc3403
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2f07d5c702
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Notes from testing: 1. Screen.Recording.2026-05-18.at.12.41.59.mov2. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3c462f2f9a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
ovitrif
changed the title
ovitrif
force-pushed
the
feat/calculator-widget-v61
branch
from
122da44 to
87b302a
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 87b302a6fc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 038338ec9e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: d007e0500d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
Tested on iPhone 17 simulator and iPhone SE on-device: It basically only works when the calculator widget is at the very top. In every other case the widget is behind the custom keyboard, even when there would be enough space it "pulls" it down again behind the number pad. Also, I found myself repeatedly in a state where I could not scroll back up to the home screen again. Simulator.Screen.Recording.-.iPhone.17.-.2026-05-21.at.16.46.09.movI'm wondering what is the reasoning for moving away from the on-screen keyboard? Also not clear how this would look for with small variant in the next iteration. |
3 participants
Description
This PR:
ovi/calculator-os-widget-v61-backup-ios.Linked Issues/Tasks
Related: synonymdev/bitkit-android#942
Screenshot / Video
Not attached in this pass.
QA Notes
Manual Tests
1: modern Bitcoin uses space grouping and fiat conversion updates.1, decimal,0: one-decimal input shows the dimmed trailing zero placeholder in the fixed input position without cursor spacing/jump.regression:Settings → General → Default Unit → switch Modern/Classic → Home → Calculator widget: Bitcoin amount is preserved while denomination formatting changes.Automated Checks
BitkitTests/CalculatorWidgetTests.swiftcovers calculator grouping, decimal placeholder behavior, number-pad delete/clear, decimal caps, localized comma input normalization, localized decimal key handling, fiat-only persistence, symbol shortening, classic BTC-to-sats conversion, and classic BTC max-supply rejection.swiftformatpassed for changed Swift files.node scripts/validate-translations.jspassed with 0 errors.git diff --checkpassed.xcodebuild -workspace Bitkit.xcodeproj/project.xcworkspace -scheme Bitkit -configuration Debug -destination 'platform=iOS Simulator,name=iPhone Air,OS=26.4' -derivedDataPath build/CalculatorWidgetTests -only-testing:BitkitTests/CalculatorWidgetTests build-for-testingpassed.LDKNodeFFI.frameworksimulator install stub from DerivedData, thenxcodebuild ... test-without-building -only-testing:BitkitTests/CalculatorWidgetTestspassed with 11 tests and 0 failures.xcrun simctl launch 90203221-2CC7-46AA-8370-759E31ED06FC to.bitkitpassed after the replay, and a screenshot confirmed Home rendered with the regtest wallet state.xcodebuild ... -destination 'id=00008150-001C691C2604401C' ... buildpassed; after removing the known staticLDKNodeFFI.frameworkdevice install stub,xcrun devicectl device install app ... Bitkit.appinstalled successfully. Launch was blocked by the physical device lock screen, so no on-device runtime smoke was observed.