test: paykit stabilization#160
Merged
Merged
Conversation
Collaborator
Author
|
@cursor review |
piotr-iohk
added
Android
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Bugbot reviewed your changes and found no new issues!
Comment @cursor review or bugbot run to trigger another review on this PR
Reviewed by Cursor Bugbot for commit eba0f26. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Low risk: changes are limited to test helpers/spec timing and assertions, with no production logic impact; main risk is altering shared helper defaults that could affect other E2E tests’ expectations.
Overview
Improves E2E stability around adding contacts and paying via Paykit.
addContactnow acceptswaitToastToDisappear(defaulting to iOS behavior) and the Paykit test opts into waiting for the save toast to fully clear.verifyAddContactRoutereplaces a booleanisDisplayedcheck with awaitForDisplayed({ reverse })assertion forAddContactPay(with a clearer timeout message), and the pay flow adds an extra pre-click delay beforeContactPayto reduce flakiness.Reviewed by Cursor Bugbot for commit eba0f26. Bugbot is set up for automated code reviews on this repo. Configure here.