Skip to content

Fix/msat invoice precision#141

Open
piotr-iohk wants to merge 8 commits intomainfrom
fix/msat-invoice-precision
Open

Fix/msat invoice precision#141
piotr-iohk wants to merge 8 commits intomainfrom
fix/msat-invoice-precision

Conversation

@piotr-iohk
Copy link
Copy Markdown
Collaborator

@piotr-iohk piotr-iohk commented Apr 2, 2026

Summary

  • add LNURL msat-precision coverage for fixed min == max pay/withdraw flows in lnurl.e2e.ts
  • add a dedicated @send_3 scenario in send.e2e.ts that pays regular invoices created with lnd.addInvoice({ valueMsat })
  • cover msat edge cases with different remainders (222538, 222222, 500500) and keep assertions focused on send success + activity behavior

Test plan

  • run npm run e2e:ios -- --spec ./test/specs/lnurl.e2e.ts
  • run npm run e2e:ios -- --spec ./test/specs/send.e2e.ts
  • run Android equivalents for both specs

Bitkit PRs

@piotr-iohk piotr-iohk added Android Changes related to bitkit-android iOS Changes related to bitkit-ios labels Apr 2, 2026
@piotr-iohk piotr-iohk self-assigned this Apr 2, 2026
@piotr-iohk piotr-iohk mentioned this pull request Apr 2, 2026
3 tasks
@piotr-iohk piotr-iohk force-pushed the fix/msat-invoice-precision branch 2 times, most recently from 25d4378 to aa9f551 Compare April 2, 2026 10:36
@piotr-iohk piotr-iohk force-pushed the fix/msat-invoice-precision branch from f39e789 to ef27452 Compare April 2, 2026 18:01
@piotr-iohk piotr-iohk force-pushed the fix/msat-invoice-precision branch from d8dc4c5 to f0cfd1a Compare April 3, 2026 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Android Changes related to bitkit-android iOS Changes related to bitkit-ios

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant