Skip to content

fix: polish widgets foundation#952

Merged
jvsena42 merged 1 commit into
masterfrom
ovi/widgets-v61-polish
May 20, 2026
Merged

fix: polish widgets foundation#952
jvsena42 merged 1 commit into
masterfrom
ovi/widgets-v61-polish

Conversation

@ovitrif
Copy link
Copy Markdown
Collaborator

@ovitrif ovitrif commented May 18, 2026

Fixes #936
Supersedes #946

This PR restores the widget foundation polish from #946 as a standalone branch targeting master and fixes the new issue related to Weather Widget fee currency symbol, documented in #936.

Description

This PR:

  1. Shows the wide in-app widget preview by default and hides small preview variants that cannot be added yet.
  2. Aligns widget preview and configuration screens with the shared Bitkit screen background and edge-to-edge system bar styling.
  3. Makes the Facts OS widget open Bitkit when tapped.
  4. Enables Android's OS widget reconfigure affordance for Price, Headlines, Blocks, and Weather.
  5. Fixes the Price widget formatter so stored price text does not duplicate the currency symbol rendered by the widget UI.

Preview

Walkthrough
Wide-only Preview slide, In-App & OS Widgets Preview system bars & screen bg, Weather widget currency, No duplicate Price Widget currency for non-US locale, OS Widget Settings menu & drop area
scrcpy.2026-05-20.005922.2.mp4

QA Notes

Manual Tests

  • 1. Home -> Widgets -> Add Widget: widget previews open on the wide preview and do not expose unavailable small variants.
  • 2. Android launcher -> add Facts widget -> tap widget: Bitkit opens.
  • 3a. Android launcher -> long-press Price widget -> Widget settings: Bitkit widget config opens.
    • 3b. Android launcher -> long-press Headlines, Blocks, and Weather widgets -> Widget settings: Bitkit widget config opens.
  • 4. Widget config -> open Price, Headlines, Blocks, or Weather config: system bars match Bitkit edge-to-edge styling.
  • 5. Android launcher -> view Price widget in a non-US locale: price text does not duplicate the currency symbol.
    [x] 6. Android launcher -> tap Facts widget -> Bitkit app opens wallet overview.

Automated Checks

  • ./gradlew testDevDebugUnitTest --tests to.bitkit.data.widgets.PriceServiceTest
  • git diff origin/master..HEAD --check

@ovitrif ovitrif self-assigned this May 20, 2026
@ovitrif ovitrif mentioned this pull request May 20, 2026
10 tasks
@ovitrif ovitrif changed the title fix: polish widget foundation fix: polish widgets foundation May 20, 2026
@ovitrif ovitrif force-pushed the ovi/widgets-v61-polish branch from 86b50ba to 03df642 Compare May 20, 2026 12:03
@ovitrif ovitrif added this to the 2.4.0 milestone May 20, 2026
@ovitrif ovitrif force-pushed the ovi/widgets-v61-polish branch from 03df642 to c4f052e Compare May 20, 2026 14:01
@ovitrif ovitrif modified the milestones: 2.4.0, 2.3.0 May 20, 2026
@ovitrif ovitrif force-pushed the ovi/widgets-v61-polish branch from c4f052e to 061dfef Compare May 20, 2026 16:07
@ovitrif ovitrif force-pushed the ovi/widgets-v61-polish branch from 061dfef to 7f628af Compare May 20, 2026 16:08
@ovitrif ovitrif marked this pull request as ready for review May 20, 2026 16:09
@ovitrif ovitrif requested a review from piotr-iohk May 20, 2026 16:09
Copy link
Copy Markdown
Member

@jvsena42 jvsena42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested

  • All preview screens display only wide widget
  • All preview and edit screens have black BG
  • New settings option displayed on hold widget
  • Change currency update weather widget
  • Facts widget click open the app

@jvsena42 jvsena42 enabled auto-merge May 20, 2026 17:09
@jvsena42 jvsena42 merged commit 2ecf194 into master May 20, 2026
37 of 39 checks passed
@jvsena42 jvsena42 deleted the ovi/widgets-v61-polish branch May 20, 2026 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Polish Widgets Foundation

2 participants