fix: handle cjit channel ready notification#787
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #666
This PR:
NotifyChannelReadyCQRS command and handler to process CJIT payment notifications when a JIT channel becomes readyAppViewModel.notifyChannelReady()to use the new handler, consolidating duplicated CJIT logicDescription
When a CJIT payment arrives as a JIT channel opening, LDK emits
ChannelReady(notPaymentReceived). The foreground service (LightningNodeService) only handledPaymentReceivedandOnchainTransactionReceived, so CJIT payments were silently ignored. The background path (WakeNodeWorker) already handled this correctly.The new
NotifyChannelReadyHandlerencapsulates channel lookup, CJIT verification via Blocktank, activity recording, and notification building. It follows the same CQRS pattern as the existingNotifyPaymentReceivedHandler.Preview
QA Notes
1. CJIT notification via foreground service
2. CJIT notification via push (WakeNodeWorker)
3. Non-CJIT channel opening
4. Unit tests
./gradlew testDevDebugUnitTest --tests NotifyChannelReadyHandlerTest— 6 tests pass./gradlew testDevDebugUnitTest— all tests pass./gradlew detekt— no new lint issues