Return null when csrfToken is not valid #8062
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I am not 100% sure of this change, but throwing an `InvalidCsrfTokenException` when the csrfToken is not valid makes the framework redirect to the url returned by `getLoginUrl` method, and from there, it keeps redirecting in a loop until the browser kills the redirections. According to the documentation for `getCredentials` method, it should return `null` when there is some parameter missing, so I guess `null` is the correct value to return when the csrfToken validation fails.
HeahDude
reviewed
Jul 29, 2017
| if (false === $this->csrfTokenManager->isTokenValid(new CsrfToken('authenticate', $csrfToken))) { | ||
| throw new InvalidCsrfTokenException('Invalid CSRF token.'); | ||
| return null; |
Contributor
There was a problem hiding this comment.
Hello @rubenrubiob, as said in #7996, such change is wrong as it would allow another guard to try to authenticate this request. To stop the process here an exception needs to be thrown.
Contributor
Author
There was a problem hiding this comment.
Hi, @HeahDude ,
Okay, I see it now. Nevertheless, if you throw an exception the application stays in a redirect loop until the browser kills it. Anyway, I will look further onto it in September, to try to solve the problem directly.
Thank you!
Regards.
Member
|
Closing because this change doesn't look entirely correct ... although some change may bee needed to avoid the loop mentioned by @rubenrubiob. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am not 100% sure of this change, but throwing an
InvalidCsrfTokenExceptionwhen the csrfToken is not valid makes the framework redirect to the url returned bygetLoginUrlmethod, and from there, it keeps redirecting in a loop until the browser kills the redirections.According to the documentation for
getCredentialsmethod, it should returnnullwhen there is some parameter missing, so I guessnullis the correct value to return when the csrfToken validation fails.