This repository was archived by the owner on Oct 28, 2024. It is now read-only.
Add SHA224, SHA384, SHA512, AES192, AES256 support#70
Draft
Add SHA224, SHA384, SHA512, AES192, AES256 support#70
Conversation
Author
|
@HoneyryderChuck You might want to have a look into this :-) |
Collaborator
|
Hey @stillhart , cool to see these extensions coming to the mainline :) I see you're still working on making the tests pass. I'll let you finish before starting the review. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added this code from an internal fork which supports more and better encryption:
SHA224, SHA256 (already supported), SHA384, SHA512, AES192, AES256 support
It probably needs a refactoring and I'm fine if anyone provides a nicer solution.