Move email sending until after payment has been created#143
Merged
Conversation
Fix bug: update_door_access needs an is_admin value
T3GG55
approved these changes
May 1, 2026
theorbtwo
approved these changes
May 1, 2026
Member
theorbtwo
left a comment
theorbtwo
left a comment
There was a problem hiding this comment.
Minor change suggested, but approved anyway.
| my $r_email = $self->communications_rs->find({type => 'reminder_email'}); | ||
| $r_email->delete if $r_email; | ||
| } | ||
| my $is_rejoining = $valid_date && $valid_date < $now ? 1 : 0; |
Member
There was a problem hiding this comment.
The ? 1 : 0 to is unnecessary and (potentially) confusing here. It's only being used as a bool, so exactly what true value and false value get used is irrelevant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix bug: update_door_access needs an is_admin value