Draft
Conversation
This avoids unintentional possible ARC traffic if `InstructionTranslator` is accidentally copied, as it stores references to classes like `ISeqAllocator`.
a0cd63c to
f702339
Compare
Member
Author
|
Only builds with |
Member
|
Very concerning that the ASan fuzz detected invalid memory access 🤔 https://github.com/swiftwasm/WasmKit/actions/runs/18654651206/job/53180660404?pr=209 |
Member
|
If I'm not mistaken, it seems like the SIL code tries to destroy struct members twice when an Error is thrown during the translator init. |
…able-translator # Conflicts: # Sources/WasmParser/BinaryInstructionDecoder.swift # Sources/WasmParser/InstructionVisitor.swift # Utilities/Sources/WasmGen.swift
Comment out the Windows build steps in the CI workflow.
Re-enable Windows build workflow with latest `main` development snapshots.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This avoids unintentional possible ARC traffic if
InstructionTranslatoris accidentally copied, as it stores references to classes likeISeqAllocator.