Fix some cases where AbsolutePath::relative(to: AbsolutePath) would assert on Windows #534
+31
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
daveinglis
commented
Dec 9, 2025
daveinglis
commented
- there where a couple case where relative(to:) would assert on windows when a path was long (>260) and when tailing slashes where not removed in some cases.
Contributor
Author
|
@swift-ci test |
Contributor
Author
|
@swift-ci test linux |
compnerd
reviewed
Dec 10, 2025
Sources/TSCBasic/Path.swift
Outdated
| while !substring.isEmpty && substring.utf8.last == UInt8(ascii: "\\") { | ||
| substring = substring.dropLast() | ||
| } | ||
| if !substring.isEmpty && substring.last != ":" { |
Member
There was a problem hiding this comment.
This is kinda sketchy. The last character being : could be a malformed path, e.g. C:\file.txt:.
Sources/TSCBasic/Path.swift
Outdated
| if !substring.isEmpty && substring.last != ":" { | ||
| // Drop the trailing '\', unless the string path only | ||
| // has '\', and unless the slashes are right after the drive letter. | ||
| path = String(substring) |
Contributor
There was a problem hiding this comment.
Just to confirm - C: and C:\ have completely different meanings. Is this logic preserving the trailing slash in the case where the path is pointing at a drive root?
daveinglis
force-pushed
the
fix_asserts
branch
from
fa18bdd to
975683d
Compare
…ssert - there where a couple case where relative(to:) would assert on windows when a path was long (>206) and when tailing slashes where not removed in some cases.
daveinglis
force-pushed
the
fix_asserts
branch
from
975683d to
df81ada
Compare
Contributor
|
@swift-ci test |
Contributor
Author
|
@swift-ci test windows |
Contributor
Author
|
This needs some more work/investigation, seeing some strange crashes in swiftPM that this is causing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.