@JavaMethod which crashes now includes whole exception stacktrace #537
+3,222
−478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
commented
Jan 22, 2026
| fatalError("Java call threw unhandled exception: \\(error)\\n\\(sw.toString())") | ||
| } | ||
| fatalError("Java call threw unhandled exception: \\(error)") | ||
| """ |
Collaborator
Author
There was a problem hiding this comment.
The actual™ change, this is what we want to make possible -- everything else in this patch is just moving around types so we're able to generate and use this code.
…Trace(_ writer: PrintWriter?)
ktoso
force-pushed
the
wip-throwble-better-error-printing-wrap-java
branch
from
c38f06c to
35c8f76
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we'd get a single line or exception's "message". This is not actionable at all usually as the
reasonmay contain more information about the issue.Making this change was difficult because we need
SwiftJava/Throwableto gainopen func printStackTrace(_ writer: PrintWriter?)and in order to do that we need to getPrintWriterinto that module. So we take it fromJavaIOwhich then causes a cascade of problems related to missing types, so we need to lower them all intoSwiftJava/.As such, this change is 4 lines in the generator, and then TONS OF moving around types and adding
StringWriterandPrintWriterso we can use the new API. This is effectively just moving around where we generate the wrappers, and then making use of it.Since the wrap-java command now is adding comments, some existing types got those as well.
We did not lose any methods in this process.