Fix incorrect BOM (Byte Order Mark) skipping behavior when converting UTF-8 to UTF-16 in fragmented data scenarios. #925
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… UTF-8 to UTF-16 in fragmented data scenarios. Also part of Apple's current libdispatch: The UTF-8 to UTF-16 transformation was skipping BOM characters (`0xFEFF`) whenever they were encountered, regardless of their logical position in the data. This caused incorrect behavior when: - Data was split across multiple chunks in `dispatch_data_apply` callbacks - A BOM appeared in the middle of the data (offset > 0) The bug occurred because the BOM skip check only examined the character value (`wch == 0xfeff`) without verifying it was at the logical start of the data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also part of Apple's current libdispatch:
The UTF-8 to UTF-16 transformation was skipping BOM characters (
0xFEFF) whenever they were encountered, regardless of their logical position in the data. This caused incorrect behavior when:dispatch_data_applycallbacksThe bug occurred because the BOM skip check only examined the character value (
wch == 0xfeff) without verifying it was at the logical start of the data.