Code Action | expand ternary expr#2461
Closed
redne-w wants to merge 2 commits intoswiftlang:mainfrom
Closed
Conversation
Add the sourcekitd "expand.ternary.expr" refactoring to the superseded list to prevent duplicate code actions now that we have a swift-syntax implementation. Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
redne-w
requested review from
ahoppen,
hamishknight and
rintaro
as code owners
10 tasks
ahoppen
reviewed
Jan 29, 2026
Member
ahoppen
left a comment
ahoppen
left a comment
There was a problem hiding this comment.
High-level comment: I don’t think you need to re-implement what you’ve done in swiftlang/swift-syntax#3247. Just make ExpandTernayrExpr conform to SyntaxCodeActionProvider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code Action -- Expand ternary Expr
Registered the code action for expand ternary expr.
Supress sourcekitd implementation of the same code action.