Skip to content

Fix crash in emulator launch in android-emulator-tests.sh #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
marcprux wants to merge 9 commits into
base: main
Choose a base branch
from
+19 −4
Open

Fix crash in emulator launch in android-emulator-tests.sh #223

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
9ab5614
Wait briefly before starting to poll the emulator in android-emulator…
marcprux Jan 11, 2026
bf32aa7
Merge branch 'swiftlang:main' into android-sleep-before-adb
marcprux Jan 13, 2026
eb3dac9
Poll emulator with adb shell getprop sys.boot_completed and manually …
marcprux Jan 14, 2026
6c0dc59
Remove unused workflow
marcprux Jan 14, 2026
6cf9eb9
Update adb check for sys.boot_completed
marcprux Jan 14, 2026
81d8b21
Update adb check for sys.boot_completed
marcprux Jan 14, 2026
a2722fb
Update adb check for sys.boot_completed
marcprux Jan 14, 2026
b3ba408
Update adb check for sys.boot_completed
marcprux Jan 14, 2026
cecb78e
Syntax cleanup in android-emulator-tests.sh
marcprux Jan 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 19 additions & 4 deletions .github/workflows/scripts/android/android-emulator-tests.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,10 +95,25 @@ log "Starting Android emulator"
# launch the emulator in the background
nohup emulator -no-metrics -partition-size 1024 -memory 4096 -wipe-data -no-window -no-snapshot -noaudio -no-boot-anim -avd "${ANDROID_EMULATOR_NAME}" &

log "Waiting for Android emulator startup"
adb start-server
sleep 5
timeout "${ANDROID_EMULATOR_TIMEOUT}" adb wait-for-any-device
EMULATOR_CHECK_SECONDS_ELAPSED=0
EMULATOR_CHECK_INTERVAL=5 # Seconds between status checks
while true; do
sleep "$EMULATOR_CHECK_INTERVAL"
((EMULATOR_CHECK_SECONDS_ELAPSED+=EMULATOR_CHECK_INTERVAL))
log "Waiting for Android emulator startup ($EMULATOR_CHECK_SECONDS_ELAPSED)"

# Check if the boot is completed
# 'adb shell getprop sys.boot_completed' returns 1 when done
# Ignore failure status since it will fail with "adb: device offline"
BOOT_STATUS=$(adb shell getprop sys.boot_completed || true 2>/dev/null | tr -d '\r')

if [ "$BOOT_STATUS" == "1" ]; then
log "Emulator is ready"
break;
elif [ "$EMULATOR_CHECK_SECONDS_ELAPSED" -ge "$ANDROID_EMULATOR_TIMEOUT" ]; then
fatal "Timeout reached ($ANDROID_EMULATOR_TIMEOUT seconds). Aborting."
fi
done

log "Prepare Swift test package"
# create a staging folder where we copy the test executable
Expand Down