[Fixed] Typo of roonName to roomName #25
Open
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ial, like permissions on supply crate in room 2 not being set
Member
|
Definitely appreciate the fix, the tutorial is something that is pending to be addressed. All Core3 code fixes are through Gerrit which can be found here: https://review.swgemu.com/q/status:open Once you get it pushed to Gerrit, I can merge it. This Repo is just a mimic of our self hosted repo, so it is downstream. |
Author
|
Apologies, thanks for the clarification on the workflow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which fixes some issues in tutorial, like permissions on supply crate in room 2 not being set