Skip to content

Conversation

@dldl-cmd
Copy link

Description

  • remove conversions of operation properties which aren't used from immutablejs to plain javascript
  • use cache for schemas

Motivation and Context

Fixes: #10681 by removing unnecessary conversions from immutablejs objects to plain javascript objects

How Has This Been Tested?

Opening after the fix an previously opened operation happens now faster. A performance profile shows that no significant time is spent in calls to toJS.

performanceProfileWithFixes

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

- remove conversions of operation properties which aren't used
- use cache for schemas
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Performance issues with large request body schema

1 participant