Issue #2216 and #2211: Parameter inline with setResolve#2254
Issue #2216 and #2211: Parameter inline with setResolve#2254nicolaideffremo wants to merge 6 commits intoswagger-api:masterfrom
Conversation
|
@ewaostrowska at #2216 (comment) you stated that you had created an internal issue for this bug. Can we expect this to get reviewed any time soon? @daniel-kmiecik FYI (discussion at #2211) |
99f5b3e to
98e42aa
Compare
98e42aa to
f3f3867
Compare
|
@ewaostrowska It has been a while. Is there anything preventing this change from being viewed? |
|
@ewaostrowska @damian-jankowski @daniel-kmiecik we've now been maintaining our own fork for some time due to this issue, which isn't sustainable long-term. Thanks @nicolaideffremo for providing this fix 👍. We genuinely want to contribute back and avoid the maintenance burden, but we need some signal from the team to know how to move forward. We'd really appreciate even a brief response: do you consider this a bug? If not, why? If yes, is there something about the proposed fix that doesn't work for you? We're happy to iterate on the patch if needed. |
|
Thanks for taking the time to contribute and share your thoughts here. We’re trying to keep up with a growing number of issues, PRs, and discussions, but our time is limited. Because of that, we’re not always able to jump on everything right away, even if it’s valid or useful. We appreciate your patience, and we hope you’ll keep contributing and sharing ideas going forward! |
|
Thanks for the approval. We certainly appreciate your diligence. |
Pull Request
Thank you for contributing to swagger-parser!
Please fill out the following checklist to help us review your PR efficiently.
Description
As described in the linked issues parameters with defined
$refare replaced bit the definition when parsed withsetResolve(true).Fixes: #2216 and #2211
Type of Change
Checklist