fix(resolver): re-evaluate element to be transcluded#4191
Draft
fix(resolver): re-evaluate element to be transcluded#4191
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue where resolving a subtree would cause it to be
null.This issue could be seen in Swagger Editor when trying to edit an operation that was expanded in Swagger UI - sometimes the operation would disappear. The resolver was called 3 times with the expanded operation and the last one would sometimes return
null. This was caused by the transcluder being unable to find the element that should be replaced inside of the original spec, most likely due to mutations that happened to the dereferenced element. To prevent this, an additional evaluation of JSON pointer was added to find the original element and try to transclude it instead of the mutated one.