Tests for issue #4341: ArraySchema.arraySchema.requiredMode not working#5015
Open
ewaostrowska wants to merge 1 commit intoswagger-api:masterfrom
Open
Tests for issue #4341: ArraySchema.arraySchema.requiredMode not working#5015ewaostrowska wants to merge 1 commit intoswagger-api:masterfrom
ewaostrowska wants to merge 1 commit intoswagger-api:masterfrom
Conversation
- Test 1: Reproduces ArraySchema.arraySchema.requiredMode not working - Test 2: Validates workaround using schema.requiredMode - Minimal test models - Focused on issue reproduction only See: swagger-api#4341
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds minimal bug reproduction tests for issue #4341.
Problem
After replacing
requiredwithrequiredModein #4286, the issue #3438 has reappeared. When using@ArraySchemawithrequiredModeonarraySchema, the field is not marked as required in the generated schema.Tests Added
Test 1: testArraySchemaRequiredMode()
Test 2: testWorkaround()
Expected Behavior
Should generate:
{ "Person": { "required": ["addresses"] } }Current Workaround
References
Closes #4341
Related to #3438, #4286
Checklist